Update textual to 3.4.0#524
Merged
Merged
Conversation
JoeZiminski
force-pushed
the
pin_textual_3_4
branch
from
2ee5d9e to
d8a86c0
Compare
JoeZiminski
added a commit
that referenced
this pull request
Dec 16, 2025
Textual was pinned to `3.4.0` in #524 but since many versions have been released. Let's see how things go when updating the pin to be `>3.4.0`.
Merged
JoeZiminski
added a commit
that referenced
this pull request
Dec 17, 2025
* Pin textual `>=3.4.0` Textual was pinned to `3.4.0` in #524 but since many versions have been released. Let's see how things go when updating the pin to be `>3.4.0`. * Use Label not Static. * Swap test order to see how general this error is. * Fix .renderable. * Revert Static->Label change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pins to textual version
3.4.0.It is an extension of #520, however this change made all
[in strings be interpreted as mkarup style syntax, resulting in many crashes. In3.4.0this was reverted (unless the[]actually contains valid style syntax) so most of the changes in #520 can be removed.I will merge this without review as it is a carry over from #520. Thanks @cs7-shrey!